Skip to content

Conversation

@dyladan
Copy link
Member

@dyladan dyladan commented Sep 29, 2021

Fixes #2510

@dyladan dyladan requested a review from a team September 29, 2021 19:08
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #2511 (665a842) into main (25e5dde) will decrease coverage by 1.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2511      +/-   ##
==========================================
- Coverage   94.47%   93.21%   -1.27%     
==========================================
  Files          73      133      +60     
  Lines        2279     5008    +2729     
  Branches      504     1064     +560     
==========================================
+ Hits         2153     4668    +2515     
- Misses        126      340     +214     
Impacted Files Coverage Δ
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/environment.ts
...opentelemetry-core/src/platform/node/timer-util.ts
...emetry-core/src/platform/node/RandomIdGenerator.ts
...ntelemetry-core/src/platform/node/hex-to-base64.ts
...entelemetry-sdk-metrics-base/src/ObserverResult.ts 100.00% <0.00%> (ø)
...emetry-api-metrics/src/platform/node/globalThis.ts 100.00% <0.00%> (ø)
...elemetry-sdk-metrics-base/src/export/Controller.ts 76.00% <0.00%> (ø)
...try-sdk-metrics-base/src/export/aggregators/Sum.ts 100.00% <0.00%> (ø)
... and 60 more

@dyladan
Copy link
Member Author

dyladan commented Sep 29, 2021

/easycla

@dyladan
Copy link
Member Author

dyladan commented Sep 30, 2021

This is blocking release please review @open-telemetry/javascript-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI reliability: experimental tests consistent failure

5 participants