fix(exporter-zipkin): correct status tags names#2519
fix(exporter-zipkin): correct status tags names#2519vmarchaud merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2519 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 137 137
Lines 5042 5043 +1
Branches 1066 1067 +1
=======================================
+ Hits 4701 4702 +1
Misses 341 341
|
johnbley
left a comment
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk_exporters/zipkin.md suggests that for a status of ERROR, the error messages should be in an error tag/attribute. It specifically calls out that it overrides the generic status mapping rule. Would like to see a fix for that and a test covering the error case. See https://github.com/open-telemetry/opentelemetry-swift/pull/232/files for a recent swift change I did that was similar.
|
@johnbley Updated to be based on the zipkin specific doc. Should be already covered by Seems like unrelated rounding fail in test? |
|
Most likely unrelated. I'm running again to see if it is consistent |
Which problem is this PR solving?
As per OpenTelemetry to Zipkin Transformation spec:
Short description of the changes
Corrected the tag names (
ot.->otel.), check for unset statusFor reference: zipkin exporter in otel-java