feat(sdk-metrics): bootstrap metric streams#2636
Merged
Merged
Conversation
5 tasks
1088cca to
da450e4
Compare
Codecov Report
@@ Coverage Diff @@
## main #2636 +/- ##
==========================================
- Coverage 93.29% 92.86% -0.44%
==========================================
Files 131 143 +12
Lines 4923 5158 +235
Branches 1078 1102 +24
==========================================
+ Hits 4593 4790 +197
- Misses 330 368 +38
|
da450e4 to
e06ae29
Compare
Member
|
to those @open-telemetry/javascript-approvers who didn't see, this is now ready for review. |
legendecas
commented
Dec 13, 2021
legendecas
commented
Dec 13, 2021
vmarchaud
reviewed
Dec 13, 2021
vmarchaud
reviewed
Dec 13, 2021
vmarchaud
left a comment
Member
There was a problem hiding this comment.
did a quick pass and overall looks fine from my comprehension of the spec, i will try to review it a second time though before approving
pichlermarc
reviewed
Dec 14, 2021
pichlermarc
left a comment
Member
There was a problem hiding this comment.
Looks good, just a few nits from my side.
dyladan
reviewed
Dec 15, 2021
5 tasks
vmarchaud
approved these changes
Dec 17, 2021
dyladan
approved these changes
Dec 17, 2021
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is a prototype of the synchronous metric streams implementation described in https://docs.google.com/document/d/1EluDhj5UanNATS3hR8xx30sv55Se7uYjsGYslvNWHtc/edit#.
Bootstrap metric streams:
Related: #2574
Depends on: #2634
Type of change
How Has This Been Tested?
Checklist: