fix: tracer typo in fetchxhr examples#2680
Merged
dyladan merged 1 commit intoopen-telemetry:mainfrom Dec 21, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2680 +/- ##
=======================================
Coverage 92.52% 92.52%
=======================================
Files 144 144
Lines 5177 5177
Branches 1102 1102
=======================================
Hits 4790 4790
Misses 387 387 |
dyladan
reviewed
Dec 20, 2021
| const element2 = document.getElementById('button2'); | ||
|
|
||
| const clickHandler = (fetchFn) => () => { | ||
| const clickHandler = (fetchFn) => { |
dyladan
approved these changes
Dec 20, 2021
legendecas
approved these changes
Dec 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some minor issues in the new combined fetch plus xhr tracer-web examples that was stopping the click event from actually being executed.