fix(exporter-jaeger): add env variable for agent port#2754
Merged
legendecas merged 4 commits intoopen-telemetry:mainfrom Feb 8, 2022
blumamir:jaeger-exporter-port
Merged
fix(exporter-jaeger): add env variable for agent port#2754legendecas merged 4 commits intoopen-telemetry:mainfrom blumamir:jaeger-exporter-port
legendecas merged 4 commits intoopen-telemetry:mainfrom
blumamir:jaeger-exporter-port
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2754 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 159 159
Lines 5444 5445 +1
Branches 1142 1143 +1
=======================================
+ Hits 5078 5079 +1
Misses 366 366
|
Member
Author
|
|
vmarchaud
approved these changes
Feb 6, 2022
dyladan
approved these changes
Feb 7, 2022
legendecas
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Exporter Jaeger did not support the
OTEL_EXPORTER_JAEGER_AGENT_PORTenvironment variable from spec.Short description of the changes
Added this missing environment variable similar to the existing variable
OTEL_EXPORTER_JAEGER_AGENT_HOST.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated the relevant unit tests with the same pattern as the existing tests for agent host.
Checklist: