fix: add parentContext to onStart#2757
Merged
vmarchaud merged 4 commits intoopen-telemetry:mainfrom Feb 6, 2022
Merged
Conversation
Add parentContext argument to onStart in SpanProcessors to allow to use it in a subclass without complains by typescript.
1 task
Codecov Report
@@ Coverage Diff @@
## main #2757 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 159 159
Lines 5444 5444
Branches 1142 1142
=======================================
Hits 5078 5078
Misses 366 366
|
legendecas
approved these changes
Feb 3, 2022
vmarchaud
approved these changes
Feb 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #2756
Short description of the changes
Add parentContext argument to onStart in SpanProcessors to allow to use it in a subclass without complains by typescript.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
local
Checklist: