chore: target to es2017 in the no-polyfill target#2765
Merged
legendecas merged 3 commits intoopen-telemetry:mainfrom Feb 24, 2022
Merged
chore: target to es2017 in the no-polyfill target#2765legendecas merged 3 commits intoopen-telemetry:mainfrom
legendecas merged 3 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2765 +/- ##
=======================================
Coverage 93.41% 93.41%
=======================================
Files 159 159
Lines 5450 5450
Branches 1145 1145
=======================================
Hits 5091 5091
Misses 359 359 |
Merged
2 tasks
vmarchaud
approved these changes
Feb 6, 2022
4 tasks
dyladan
approved these changes
Feb 23, 2022
Member
|
Can this be considered a breaking change? If someone was previously targeting the |
Member
Author
We have not released this yet. So I don't think so. |
Member
|
edit: looks like I'm wrong. The PR was opened in october but was merged in december and is not released. This is not a breaking change |
3 tasks
Member
Author
|
@schickling we're working to fix it: #2844. Sorry for the inconvenience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Which problem is this PR solving?
This is a follow-up of #2556.
As the original PR claims to fix #2471, unfortunately, the problem is not resolved. The async function was introduced with es2017, so targeting es2015 is not enough and it is still been polyfill-ed. #2556 (comment)
This PR aligns the target with tsconfig.base.json (which is used for Node.js targets). Also renamed the target name as "esnext", so that we can freely upgrade the target to a later version of ECMAScript.
Another problem is that referencing projects with tsconfig suffix like ".all.json" in the root tsconfig project is not supported by the update-ts-references yet. The root tsconfig.json is always being updated during the bootstrap since the update-ts-references is invoked with after-install hook. This can be confusing, for git tracked files were updated during bootstrap of the project. These targets are only needed when publishing, so we don't have to compile them on the root project "compile" script. The pre-publish for each package invokes the "compile" script, which is compiled with the "tsconfig.all.json".
Short description of the changes
Type of change
Checklist: