feat(sdk-metrics-base): update exporting names#2829
Merged
vmarchaud merged 5 commits intoopen-telemetry:mainfrom Mar 21, 2022
Merged
feat(sdk-metrics-base): update exporting names#2829vmarchaud merged 5 commits intoopen-telemetry:mainfrom
vmarchaud merged 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2829 +/- ##
=======================================
Coverage 93.51% 93.52%
=======================================
Files 163 163
Lines 5570 5572 +2
Branches 1179 1180 +1
=======================================
+ Hits 5209 5211 +2
Misses 361 361
|
seemk
approved these changes
Mar 14, 2022
experimental/packages/opentelemetry-sdk-metrics-base/src/aggregator/Histogram.ts
Outdated
Show resolved
Hide resolved
Merged
2 tasks
rauno56
approved these changes
Mar 17, 2022
vmarchaud
approved these changes
Mar 19, 2022
# Conflicts: # experimental/packages/opentelemetry-sdk-metrics-base/src/index.ts # experimental/packages/opentelemetry-sdk-metrics-base/test/util.ts
legendecas
force-pushed
the
metrics-ff/exporters
branch
from
96ef778 to
9fcf82e
Compare
pichlermarc
approved these changes
Mar 21, 2022
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
LGTM! 🙂
Just one nit: the rename from _instrumentDescriptor -> _descriptor is still missing in aggregator/Drop.ts
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
HistogramInstrument class name is conflict with the data typeHistogram. Renames all instrument classes with the suffixInstrument.MetricData: pluralpointData->dataPoints, shorteninstrumentDescriptor->descriptorsince the interface already represents an instrument.Extracted from #2824
Type of change
Checklist: