fix(otlp-http-exporter): remove content length header#2879
Merged
dyladan merged 6 commits intoopen-telemetry:mainfrom Apr 6, 2022
Merged
fix(otlp-http-exporter): remove content length header#2879dyladan merged 6 commits intoopen-telemetry:mainfrom
dyladan merged 6 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2879 +/- ##
=======================================
Coverage 93.42% 93.42%
=======================================
Files 162 162
Lines 5564 5564
Branches 1175 1175
=======================================
Hits 5198 5198
Misses 366 366 |
Flarna
reviewed
Apr 1, 2022
experimental/packages/exporter-trace-otlp-http/src/platform/node/util.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Flarna
approved these changes
Apr 4, 2022
experimental/packages/exporter-trace-otlp-http/src/platform/node/util.ts
Outdated
Show resolved
Hide resolved
Member
|
CI fails because a changelog entry is needed now (see #2847). |
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
Signed-off-by: Svetlana Brennan <svetlana.svn@gmail.com>
6 tasks
MSNev
approved these changes
Apr 6, 2022
dyladan
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Svetlana Brennan svetlana.svn@gmail.com
Which problem is this PR solving?
OTLP/HTTP and OLTP/PROTO trace exporters are unable to export when gzip compression is used.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2876
Short description of the changes
Removed
content-lengthheader when gzip is used. Content-length header was setting the uncompressed length which was causing a timeout export issue.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated existing unit test
Checklist: