Merge back into a single lerna monorepo

[dyladan]

This is attempting to solve several pain points we've had which stem from the fact that our stable and experimental packages are not linked by lerna and aren't released together.

• Merge into a single monorepo keeping packages in the same directories for now
• Relax API dependencies to ^1.0.0 or >=1.0.0 <1.2.0 in order to facilitate using older APIs
  • includes reverting fix: use api 1.1 in SDKs #2759
• Remove API peer dependency check
  • It checks that peer dependencies match dev dependencies, which isn't what we want

Keeping this as a draft for now

[codecov]

Codecov Report

Merging #2892 (dc0cad6) into main (7086d5a) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

❗ Current head dc0cad6 differs from pull request most recent head 9e90e2a. Consider uploading reports for the commit 9e90e2a to get more accurate results

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
- Coverage   92.76%   92.48%   -0.29%     
==========================================
  Files         163      151      -12     
  Lines        5516     4841     -675     
  Branches     1159     1022     -137     
==========================================
- Hits         5117     4477     -640     
+ Misses        399      364      -35     

Impacted Files	Coverage Δ
...metry-core/src/trace/sampler/ParentBasedSampler.ts	83.87% <ø> (ø)
...ges/opentelemetry-exporter-zipkin/src/transform.ts	100.00% <ø> (ø)
packages/opentelemetry-resources/src/Resource.ts	100.00% <ø> (ø)
...ckages/opentelemetry-core/src/common/attributes.ts	93.02% <100.00%> (-0.32%)	⬇️
...elemetry-sdk-trace-base/src/BasicTracerProvider.ts	94.49% <100.00%> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts	99.18% <100.00%> (ø)
...ackages/opentelemetry-shim-opentracing/src/shim.ts	94.25% <100.00%> (ø)
...metrics-otlp-http/src/OTLPMetricExporterOptions.ts
...emetry-instrumentation-xml-http-request/src/xhr.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
... and 9 more

[legendecas]

AFAICT, Lerna can only bump all changed packages to the same version -- this is not what we expect of stable packages and experimental packages release works. Is yarn workspace an available choice? I found that react is using yarn workspace and publishes packages with different versions (scheduler v0.21.0, and react v18.0.0) at one time.

[dyladan]

AFAICT, Lerna can only bump all changed packages to the same version -- this is not what we expect of stable packages and experimental packages release works.

My current plan is to use lerna independent mode and to create automations to ensure the stable packages are versioned together and the experimental packages are versioned together.

Is yarn workspace an available choice? I found that react is using yarn workspace and publishes packages with different versions (scheduler v0.21.0, and react v18.0.0) at one time.

We considered yarn workspaces a long time ago and I can't remember exactly why it was rejected. I think it had to do with supporting old node versions but I could be wrong. NPM now also has workspace support but only for npm 7+.

[legendecas]

My current plan is to use lerna independent mode and to create automations to ensure the stable packages are versioned together and the experimental packages are versioned together.

Oh, now I know lerna supports independent mode :O. This sounds great and may fit our use case.

[dyladan]

@open-telemetry/javascript-approvers sorry for the delay but this is ready to be reviewed now. Its a lot of files changed but should be relatively easy to review.

[Flarna]

This seems outdated

[Flarna]

Is it intended to use ~ here even for components which are now in the same lerna project?

[dyladan]

I think we should probably pin them

[Flarna]

Is it intended to have api-metrics as peer dependency here but as dependency in opentelemetry-sdk-metrics-base?

[legendecas]

I'm confused by the @opentelemetry/api version change. What benefit can we gain on that change?

[dyladan]

I'm confused by the @opentelemetry/api version change. What benefit can we gain on that change?

The specification requires that an SDK support old API versions. This allows users to freely update their SDK without fear that dependencies which use an older API will break.

[vmarchaud]

looks fine for lerna but i'm not sure to understand why we changed back to SpanAttributes instead of Attributes ? Is this to support TS user with latest SDK but API <1.1 ?

[dyladan]

looks fine for lerna but i'm not sure to understand why we changed back to SpanAttributes instead of Attributes ? Is this to support TS user with latest SDK but API <1.1 ?

Yes

[legendecas]

SGTM