Skip to content

Conversation

@dyladan
Copy link
Member

@dyladan dyladan commented Apr 20, 2022

See CHANGELOG and experimental/CHANGLOG for release details.

If there are any issues or PRs which should BLOCK the release please comment them here.

@dyladan dyladan requested a review from a team April 20, 2022 17:32
@dyladan dyladan changed the title Release proposal 1.1 / 0.28 Release proposal 1.2.0 / 0.28 Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #2914 (56081d9) into main (e5031bd) will decrease coverage by 0.61%.
The diff coverage is n/a.

❗ Current head 56081d9 differs from pull request most recent head ff568a1. Consider uploading reports for the commit ff568a1 to get more accurate results

@@            Coverage Diff             @@
##             main    #2914      +/-   ##
==========================================
- Coverage   92.81%   92.19%   -0.62%     
==========================================
  Files         184       69     -115     
  Lines        6066     1999    -4067     
  Branches     1296      437     -859     
==========================================
- Hits         5630     1843    -3787     
+ Misses        436      156     -280     
Impacted Files Coverage Δ
...ckages/opentelemetry-sdk-trace-web/karma.worker.js 0.00% <0.00%> (-100.00%) ⬇️
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
...lemetry-resources/src/detectors/BrowserDetector.ts 93.33% <0.00%> (-6.67%) ⬇️
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts
...trics-base/src/exemplar/WithTraceExemplarFilter.ts
... and 113 more

@seemk
Copy link
Contributor

seemk commented Apr 21, 2022

The metrics exporters are still using ancient protos (otlpTypes from exporter-trace-otlp-http), think we could move to a newer format, via otlp-transformer package before doing a release? Or if that would delay it too much is there a possibility to cut a new, smaller release after moving to newer protos?

@dyladan
Copy link
Member Author

dyladan commented Apr 21, 2022

The metrics exporters are still using ancient protos (otlpTypes from exporter-trace-otlp-http), think we could move to a newer format, via otlp-transformer package before doing a release? Or if that would delay it too much is there a possibility to cut a new, smaller release after moving to newer protos?

Certainly we will need to release ASAP since the proto is very out of date but I think we can cut this release and another one next week for that. @pichlermarc was looking into that so maybe he has an opinion.

@dyladan dyladan force-pushed the proposal-1.1-0.28 branch from cf6407b to ff568a1 Compare April 21, 2022 15:35
@seemk
Copy link
Contributor

seemk commented Apr 21, 2022

The metrics exporters are still using ancient protos (otlpTypes from exporter-trace-otlp-http), think we could move to a newer format, via otlp-transformer package before doing a release? Or if that would delay it too much is there a possibility to cut a new, smaller release after moving to newer protos?

Certainly we will need to release ASAP since the proto is very out of date but I think we can cut this release and another one next week for that. @pichlermarc was looking into that so maybe he has an opinion.

Thanks, makes perfect sense!

@pichlermarc
Copy link
Member

Updating the protos might take a bit as we will have to update many of the tests as well. I expect to have a PR ready for that on Tuesday.

@dyladan's timeline to release the proto update next week seems realistic. 🙂

@dyladan dyladan merged commit a0a670a into open-telemetry:main Apr 22, 2022
@dyladan dyladan deleted the proposal-1.1-0.28 branch April 22, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants