chore: remove unused InstrumentationConfig#path#2944
Merged
dyladan merged 2 commits intoopen-telemetry:mainfrom May 4, 2022
Merged
chore: remove unused InstrumentationConfig#path#2944dyladan merged 2 commits intoopen-telemetry:mainfrom
dyladan merged 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2944 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 185 185
Lines 6089 6089
Branches 1304 1304
=======================================
Hits 5661 5661
Misses 428 428 |
Member
Author
|
Actually I'm not sure if changes like this in experimental modules should be marked as breaking or housekeeping. |
blumamir
approved these changes
May 2, 2022
Member
I think it's ok to mark it as chore in this case |
legendecas
approved these changes
May 4, 2022
Member
legendecas
left a comment
There was a problem hiding this comment.
There is an upgrade guideline https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines that describes the (possible) breaking changes with experimental versions. Maybe we can add an entry to it. Either way, this is lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Removed the unused field
InstrumentationConfig#pathas it seems it's not used anywhere. The comment there is also outdated so can't tell if it was ever used.Type of change
How Has This Been Tested?
CI
Checklist: