fix(sdk-metrics-base): only record non-negative histogram values.#3002
Merged
vmarchaud merged 5 commits intoopen-telemetry:mainfrom May 30, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3002 +/- ##
=======================================
Coverage 92.77% 92.78%
=======================================
Files 183 183
Lines 6134 6137 +3
Branches 1300 1301 +1
=======================================
+ Hits 5691 5694 +3
Misses 443 443
|
legendecas
approved these changes
May 30, 2022
vmarchaud
approved these changes
May 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Currently, Histograms allow for negative values to be recorded. However, the spec states this for parameters of the Histogram
record()function:This PR changes the Histogram Implementation to drop negative values and to log when they are passed to
record(). This behavior is in line with the Python and Java SDK implementations.Fixes #3001
Type of change
How Has This Been Tested?
Checklist: