Skip to content

chore: hotfix release 0.29.1 #3013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dyladan merged 5 commits into from
Jun 1, 2022
Merged

chore: hotfix release 0.29.1 #3013

dyladan merged 5 commits into from
Jun 1, 2022

Conversation

@dyladan
Copy link
Member

@dyladan dyladan commented Jun 1, 2022 •
edited
Loading

@dyladan dyladan requested a review from a team June 1, 2022 14:48
Flarna
Flarna approved these changes Jun 1, 2022
View reviewed changes
@dyladan dyladan added this to the Metrics GA milestone Jun 1, 2022
@codecov
Copy link

codecov bot commented Jun 1, 2022 •
edited
Loading

Codecov Report

Merging #3013 (b599f2b) into main (bf0783a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3013   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files          68       68           
  Lines        1850     1850           
  Branches      392      392           
=======================================
  Hits         1696     1696           
  Misses        154      154

@legendecas
Copy link
Member

legendecas commented Jun 1, 2022

Just wondering: are we still using Lerna to bump versions? IIUC, Lerna cannot handle two distinct versions, right?

@dyladan dyladan self-assigned this Jun 1, 2022
@vmarchaud
Copy link
Member

vmarchaud commented Jun 1, 2022 •
edited
Loading

There is two entries in the changelog that are on master but isn't included in the 0.29.1, is this normal ?

@dyladan
Copy link
Member Author

dyladan commented Jun 1, 2022

There is two entries in the changelog that are on master but isn't included in the 0.29.1, is this normal ?

Probably auto-merge issues since there are so many near identical lines

@dyladan dyladan merged commit 094f016 into open-telemetry:main Jun 1, 2022
@dyladan dyladan deleted the hotfix-0.29.1 branch June 1, 2022 18:15
@rauno56 rauno56 mentioned this pull request Jun 2, 2022
Merged
@jjhuff jjhuff mentioned this pull request Jun 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

+3 more reviewers

@rauno56 rauno56 rauno56 approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@Flarna Flarna Flarna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dyladan dyladan

Labels

None yet

Projects

None yet

Milestone

Metrics GA

Development

Successfully merging this pull request may close these issues.

6 participants

@dyladan @legendecas @vmarchaud @rauno56 @Flarna @pichlermarc