-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: allow extending BasicTracerProvider with custom registered components
#3023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dyladan
merged 16 commits into
open-telemetry:main
from
rauno56:feat/basic-tp-extendable
Jul 20, 2022
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
4aa4d5b
chore: remove removeEvent since it's not used anywhere
rauno56 fc995ef
test: use sinon assertions and always restore stubs and spies
rauno56 fd0ec87
test: test the common inheritance models for BasicTracerProvider
rauno56 8c769b8
test: remove clearing module cache - not required anymore
rauno56 4a9ec4d
test: implement tests for NodeTracerProvider
rauno56 b7c5ea2
feat: allow for extending BasicTracerProvider with custom registered …
rauno56 6c9b998
fix: add propagators from `BasicTracerProvider` to `NodeTracerProvider`
rauno56 1c6422a
test: refactor instanceof asserts to make it easier to debug
rauno56 9a343f6
test: make tests work with linked packages
rauno56 0eb8a44
Merge branch 'main' into feat/basic-tp-extendable
rauno56 3e48d5d
Merge branch 'main' into feat/basic-tp-extendable
dyladan 1598084
fix: remove overrides from NodeTracerProvider
rauno56 c9ff693
feat: test the getters for components from parent class
rauno56 ccf4227
Merge branch 'main' into feat/basic-tp-extendable
rauno56 61d43d5
style: fix lint
rauno56 ea6dd7e
Merge branch 'main' into feat/basic-tp-extendable
dyladan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: test the getters for components from parent class
- Loading branch information
commit c9ff69321aba5a19d5de21e29b6103ec9a65f684
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.