Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a310e37
feature(views): move views registration to MeterProvider constructor
pichlermarc Jun 29, 2022
a44657e
feature(views): introduce UserView class.
pichlermarc Jul 4, 2022
4834310
feature(views): add tests for UserView.
pichlermarc Jul 4, 2022
b8535a3
feature(views): remove View class.
pichlermarc Jul 4, 2022
ebe4d53
feature(views): rename UserView -> View.
pichlermarc Jul 4, 2022
6c511ab
feature(views): update tests.
pichlermarc Jul 4, 2022
84c3e85
feature(views): collapse options into one.
pichlermarc Jul 5, 2022
a937ffc
feature(views): verify that at least one selector option is used.
pichlermarc Jul 5, 2022
b48efde
feature(views): undo accidental re-format.
pichlermarc Jul 5, 2022
7a91b9d
feature(views): cleanup.
pichlermarc Jul 5, 2022
389521e
fix(changelog): add changelog entry.
pichlermarc Jul 5, 2022
38122b7
Merge branch 'main' into meterprovider-constructor-views
pichlermarc Jul 7, 2022
bf7caab
fix(changelog): move changelog entry.
pichlermarc Jul 7, 2022
59e69ae
fix(views): address review comments.
pichlermarc Jul 8, 2022
dc2b657
fix(views): rename isSelectorProvided -> isSelectorNotProvided
pichlermarc Jul 8, 2022
7892706
fix(views): amend documentation.
pichlermarc Jul 8, 2022
600a49c
Merge remote-tracking branch 'upstream/main' into meterprovider-const…
pichlermarc Jul 12, 2022
dd13da0
fix(meterprovider): address review comments.
pichlermarc Jul 13, 2022
87271e8
docs(sdk-metrics-base): remove empty lines.
pichlermarc Jul 13, 2022
da511f3
Merge remote-tracking branch 'upstream/main' into meterprovider-const…
pichlermarc Jul 15, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feature(views): cleanup.
  • Loading branch information
pichlermarc committed Jul 5, 2022
commit 7a91b9d15cfe607428c6f9cf38c1539d456aeab3
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ import {
AggregationTemporality,
ExplicitBucketHistogramAggregation,
MeterProvider,
MetricReader, View,
MetricReader,
View,
} from '@opentelemetry/sdk-metrics-base';
import { IKeyValue, IMetric, IResource } from '@opentelemetry/otlp-transformer';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@ import {
mockCounter,
mockObservableGauge,
mockHistogram,
collect, shutdown, setUp, HISTOGRAM_AGGREGATION_VIEW,
collect,
shutdown,
setUp,
HISTOGRAM_AGGREGATION_VIEW,
} from '../metricsHelper';
import { MockedResponse } from './nodeHelpers';
import { AggregationTemporality, ResourceMetrics } from '@opentelemetry/sdk-metrics-base';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ import {
AggregationTemporality,
ExplicitBucketHistogramAggregation,
MeterProvider,
MetricReader, View
MetricReader,
View
} from '@opentelemetry/sdk-metrics-base';
import { IExportMetricsServiceRequest, IKeyValue, IMetric } from '@opentelemetry/otlp-transformer';
import { Stream } from 'stream';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ import {
DataPointType,
ExplicitBucketHistogramAggregation,
SumAggregation,
Histogram, View,
Histogram,
View,
} from '@opentelemetry/sdk-metrics-base';
import * as sinon from 'sinon';
import { PrometheusSerializer } from '../src';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,15 @@ describe('View', () => {
});

it('without at least one selector option should throw', () => {
// would do nothing
assert.throws(() => new View({}));
// would implicitly rename all instruments to 'name'
assert.throws(() => new View({ name: 'name' }));
// would implicitly drop all attribute keys on all instruments except 'key'
assert.throws(() => new View({ attributeKeys: ['key'] }));
// would implicitly rename all instruments to description
assert.throws(() => new View({ description: 'description' }));
// would implicitly change all instruments to use histogram aggregation.
// would implicitly change all instruments to use histogram aggregation
assert.throws(() => new View({
aggregation: new ExplicitBucketHistogramAggregation([1, 100])
}));
Expand Down