-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: browser support for exporter-trace-otlp-proto #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
legendecas
merged 51 commits into
open-telemetry:main
from
pkanal:proto-exporter-browser
Jan 20, 2023
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
915ce52
add node & browser platform for exporter-trace-otlp-proto
pkanal 87327f0
add browser support for proto base exporter
pkanal b7c8c19
add base browser class with xhr support
pkanal 1fec3b3
add browser class for proto trace exporter
pkanal 4214129
slight tweaks to make it work
pkanal d33f9bb
send data as blob to avoid making sync xhr requests
pkanal 3dd4e17
fix lint
pkanal 35c193f
remove console.logs and add browser proto example
pkanal 5ed212d
cleanup and start adding tests
pkanal 933d37e
Merge branch 'main' of github.com:pkanal/opentelemetry-js into proto-…
scheler 9953561
Undo formatting changes
scheler 5e87c85
exporter-trace-otlp-proto: fix compile errors
scheler 1616d2b
Misc updates from review comments
scheler e3043b0
Merge branch 'main' of github.com:pkanal/opentelemetry-js into proto-…
scheler 0020c98
Adding changelog entry
scheler 6125ec2
Merge branch 'open-telemetry:main' into proto-exporter-browser
scheler c420fd0
Reverting format changes not needed
scheler f260db8
Merge branch 'main' into proto-exporter-browser
legendecas fb6cfd2
Merge branch 'open-telemetry:main' into proto-exporter-browser
scheler 3d9ae04
Moving the send function into the class for browser case.
scheler 46b665a
Merge branch 'main' into proto-exporter-browser
scheler 2000c41
Adjust indentation to fix lint errors
scheler 6366e4b
Remove template parameter that's not needed
scheler 50e1af0
Apply review changes
scheler 302e09c
Merge branch 'main' into proto-exporter-browser
scheler a16fcf5
fix the import path
scheler 266d293
Addressing lint errors
scheler 4cd39c0
Merge branch 'main' into proto-exporter-browser
scheler ed1835e
Merge branch 'open-telemetry:main' into proto-exporter-browser
scheler 84be752
Explicit imports for browser case
scheler d92f5fe
More explicit exports
scheler 61c7be7
Add missing exports
scheler 3eed4bb
Address lint issues with export statements
scheler c618265
Adding missing exports
scheler cbabbf1
Adding missing export
scheler 519fa7c
Using import from top level folder
scheler 5f67e56
Merge branch 'open-telemetry:main' into proto-exporter-browser
scheler ad2aa0e
Trigger Build
scheler e57f0f2
Merge branch 'proto-exporter-browser' of github.com:pkanal/openteleme…
scheler b26fd7f
Merge branch 'main' into proto-exporter-browser
pichlermarc f421989
Update experimental/packages/exporter-trace-otlp-proto/test/browser/C…
scheler 8064d5b
Remove trailing comma
scheler 2678ff3
Remove blank line to fix lint error
scheler c898ea2
Fixes based on testing opentelemetry-web/fetch-proto
scheler d48503a
Add additional missing export
scheler a800550
Skip hex conversion of traceId for the protobuf
scheler 598bc56
Add esm/esnext builds for the proto packages
scheler 5596d13
Merge branch 'main' into proto-exporter-browser
scheler 1788269
Merge branch 'main' into proto-exporter-browser
legendecas 2e0c4ec
Merge branch 'main' into proto-exporter-browser
scheler 9429864
Trigger Build
scheler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add browser support for proto base exporter
- Loading branch information
commit 87327f0203323c35657fedddbda7bbfc73473817
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
experimental/packages/exporter-trace-otlp-proto/src/platform/browser/OTLPTraceExporter.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| import { OTLPProtoExporterBrowserBase } from '@opentelemetry/otlp-proto-exporter-base' | ||
| export const OTLPTraceExporter = () => { | ||
| console.log('exporter-trace-otlp-proto') | ||
| OTLPProtoExporterBrowserBase() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 1 addition & 19 deletions
20
experimental/packages/otlp-proto-exporter-base/src/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| export { OTLPProtoExporterNodeBase } from './OTLPProtoExporterNodeBase'; | ||
| export * from './types'; | ||
| export * from './util'; | ||
| export * from './platform' |
3 changes: 3 additions & 0 deletions
3
...al/packages/otlp-proto-exporter-base/src/platform/browser/OTLPProtoExporterBrowserBase.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export const OTLPProtoExporterBrowserBase = () => { | ||
| console.log('otlp-proto-exporter-base') | ||
| } |
4 changes: 1 addition & 3 deletions
4
experimental/packages/otlp-proto-exporter-base/src/platform/browser/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1 @@ | ||
| export const OTLPExporter = () => { | ||
| console.log('browser exporter') | ||
| } | ||
| export * from './OTLPProtoExporterBrowserBase' |
2 changes: 2 additions & 0 deletions
2
experimental/packages/otlp-proto-exporter-base/src/platform/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export * from './node' | ||
| export * from './browser' |
File renamed without changes.
19 changes: 19 additions & 0 deletions
19
experimental/packages/otlp-proto-exporter-base/src/platform/node/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| export { OTLPProtoExporterNodeBase } from './OTLPProtoExporterNodeBase'; | ||
| export * from './types'; | ||
| export * from './util'; |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.