-
Notifications
You must be signed in to change notification settings - Fork 983
feat(prometheus): serialize resource as target_info gauge #3300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dyladan
merged 16 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feature/prometheus-serializer-resources
Oct 17, 2022
Merged
feat(prometheus): serialize resource as target_info gauge #3300
dyladan
merged 16 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feature/prometheus-serializer-resources
Oct 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc1e5d6 to
ccc1899
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3300 +/- ##
=======================================
Coverage 93.04% 93.05%
=======================================
Files 226 226
Lines 6517 6522 +5
Branches 1360 1360
=======================================
+ Hits 6064 6069 +5
Misses 453 453
|
dyladan
reviewed
Oct 7, 2022
legendecas
reviewed
Oct 8, 2022
experimental/packages/opentelemetry-exporter-prometheus/src/PrometheusSerializer.ts
Outdated
Show resolved
Hide resolved
…serializer-resources
legendecas
reviewed
Oct 10, 2022
experimental/packages/opentelemetry-exporter-prometheus/test/PrometheusExporter.test.ts
Show resolved
Hide resolved
legendecas
approved these changes
Oct 10, 2022
Member
|
I think the lint failure was intermittent |
dyladan
approved these changes
Oct 12, 2022
experimental/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts
Show resolved
Hide resolved
experimental/packages/opentelemetry-exporter-prometheus/src/PrometheusSerializer.ts
Show resolved
Hide resolved
vmarchaud
approved these changes
Oct 15, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR updates the
PrometheusExporterto exportResourceas agauge-typedtarget_infometric according to the specification here.service.nameandservice.namespaceare dropped from the resource attributes and used to construct thejoblabel.jobis already present in the resource, it is dropped instead.service.instance.idis dropped from the resource attributes, and its contents are added to theinstancelabel.jobis already present in the resource, it is dropped instead.Fixes #867
Short description of the changes
Export
Resourceas a singlegauge-typedtarget_infometric.Type of change
How Has This Been Tested?
Checklist: