fix(api): declare this parameter type in observable callbacks#3497
Merged
legendecas merged 3 commits intoopen-telemetry:mainfrom Jan 3, 2023
Merged
fix(api): declare this parameter type in observable callbacks#3497legendecas merged 3 commits intoopen-telemetry:mainfrom
legendecas merged 3 commits intoopen-telemetry:mainfrom
Conversation
legendecas
force-pushed
the
api/callback-this
branch
from
f31a0ee to
18da128
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3497 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 249 249
Lines 7610 7610
Branches 1587 1587
=======================================
Hits 7135 7135
Misses 475 475 |
dyladan
approved these changes
Dec 21, 2022
pichlermarc
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #3293
Declare the this parameter types for the observable callbacks.
This should not be a breaking change as usages without
thisparameter to be the expected one are not working anyways.Type of change
How Has This Been Tested?
Checklist: