fix(sdk-metrics): allow instrument names to contain '/'#4155
Merged
pichlermarc merged 1 commit intoopen-telemetry:mainfrom Sep 21, 2023
Merged
fix(sdk-metrics): allow instrument names to contain '/'#4155pichlermarc merged 1 commit intoopen-telemetry:mainfrom
pichlermarc merged 1 commit intoopen-telemetry:mainfrom
Conversation
cdce171 to
4f570e9
Compare
4f570e9 to
71bc38d
Compare
Codecov Report
@@ Coverage Diff @@
## main #4155 +/- ##
==========================================
+ Coverage 92.29% 92.30% +0.01%
==========================================
Files 328 328
Lines 9385 9385
Branches 1993 1993
==========================================
+ Hits 8662 8663 +1
+ Misses 723 722 -1
|
pichlermarc
approved these changes
Sep 20, 2023
legendecas
approved these changes
Sep 20, 2023
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #4141
Short description of the changes
Allows the
/character in metric instrument name validation.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: