Update readme #421
Merged
Update readme #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
OlivierAlbertini,
bg451,
danielkhan,
iredelmeier,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
+ Coverage 95.59% 95.79% +0.19%
==========================================
Files 108 108
Lines 5042 5162 +120
Branches 419 408 -11
==========================================
+ Hits 4820 4945 +125
+ Misses 222 217 -5
Continue to review full report at Codecov.
|
dyladan
reviewed
Oct 11, 2019
Member
dyladan
left a comment
dyladan
left a comment
There was a problem hiding this comment.
Looks good. Just a few small wording nitpicks.
README.md
Outdated
| - [@opentelemetry/exporter-jaeger](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-exporter-jaeger) | ||
| - [@opentelemetry/exporter-zipkin](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-exporter-zipkin) | ||
|
|
||
| #### Metrics Exporters |
Member
There was a problem hiding this comment.
Suggested change
| #### Metrics Exporters | |
| #### Metric Exporters |
README.md
Outdated
| | Package | Description | | ||
| | ----------------------- | -----------------| | ||
| | [@opentelemetry/tracing](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-tracing) | This module provides a full control over instrumentation and span creation. It doesn't load [`async_hooks`](https://nodejs.org/api/async_hooks.html) or any instrumentation plugin by default. It is intended for use both on the server and in the browser. | | ||
| | [@opentelemetry/metrics](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-metrics) | This module allows to report raw measurements as well as metrics with the known aggregation and labels. | |
Member
There was a problem hiding this comment.
Suggested change
| | [@opentelemetry/metrics](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-metrics) | This module allows to report raw measurements as well as metrics with the known aggregation and labels. | | |
| | [@opentelemetry/metrics](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-metrics) | This module provides instruments and meters for reporting of time series data. | |
README.md
Outdated
| | [@opentelemetry/tracing](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-tracing) | This module provides a full control over instrumentation and span creation. It doesn't load [`async_hooks`](https://nodejs.org/api/async_hooks.html) or any instrumentation plugin by default. It is intended for use both on the server and in the browser. | | ||
| | [@opentelemetry/metrics](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-metrics) | This module allows to report raw measurements as well as metrics with the known aggregation and labels. | | ||
| | [@opentelemetry/node](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-node) | This module provides automatic tracing for Node.js applications. It is intended for use on the server only. | | ||
| | [@opentelemetry/web](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-web) | This module provides automated instrumentation and tracing for Web applications. | |
Member
There was a problem hiding this comment.
Suggested change
| | [@opentelemetry/web](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-web) | This module provides automated instrumentation and tracing for Web applications. | | |
| | [@opentelemetry/web](https://github.com/open-telemetry/opentelemetry-js/tree/master/packages/opentelemetry-web) | This module provides automated instrumentation and tracing for Web applications. It is intended for use in the browser only. | |
danielkhan
approved these changes
Oct 11, 2019
bg451
approved these changes
Oct 11, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* feat: add xray propagator * chore: cleanups * Remove AWS Distro link Co-authored-by: Valentin Marchaud <[email protected]>
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
* feat: add xray propagator * chore: cleanups * Remove AWS Distro link Co-authored-by: Valentin Marchaud <[email protected]>
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Apr 2, 2024
* feat: add xray propagator * chore: cleanups * Remove AWS Distro link Co-authored-by: Valentin Marchaud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Add Web and Metrics SDK links.
Add work in progress Exporter(prometheus) and plugin(postgres).