Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1c9205f
chore: track package-lock.json
legendecas Oct 30, 2023
de24a33
Pin to old versions for node 14
dyladan Oct 30, 2023
b96c3d9
Use version range
dyladan Oct 31, 2023
1dbf56d
Remove unused cached directories
dyladan Oct 31, 2023
6f7706a
Temporarily disable other tests
dyladan Oct 31, 2023
2edd213
Temporarily enable only api test
dyladan Oct 31, 2023
68931bf
Enable only some packages
dyladan Oct 31, 2023
0bb77a0
Test only api packages
dyladan Oct 31, 2023
7aaa168
Test trace exporters
dyladan Oct 31, 2023
375ac6c
Fix line ordering
dyladan Oct 31, 2023
1041126
Test all packages except otlp exporters
dyladan Oct 31, 2023
da4ac69
Add trace http exporter
dyladan Oct 31, 2023
6b18e61
Add trace proto exporter
dyladan Oct 31, 2023
bc5f011
Test all but grpc exporters
dyladan Oct 31, 2023
f9b1dc7
chore: use npm workspaces and degrade lerna to v6
legendecas Nov 1, 2023
5093a10
chore: get rid of lerna bootstrap
legendecas Nov 1, 2023
a24e0d5
chore: use npx
legendecas Nov 1, 2023
e6b1b8f
chore: allow install scripts to setup buf
legendecas Nov 1, 2023
1c4e7e2
chore: fix w3c-integration-test cache key
legendecas Nov 1, 2023
36833f5
chore: fix cache key
legendecas Nov 1, 2023
6c47b32
chore: disable resource compat test
legendecas Nov 1, 2023
3f168db
chore: fix node_modules assumptions
legendecas Nov 1, 2023
08225f1
chore: fix hoisted karma issue
legendecas Nov 1, 2023
89113f9
chore: fix markdown linter complaints
legendecas Nov 1, 2023
e331083
chore: lock @grpc/grpc-js to v1.8.21
legendecas Nov 1, 2023
8d7f865
Break caches
dyladan Nov 1, 2023
ba0d37b
chore: remove cache
legendecas Nov 1, 2023
a639048
chore: fixup inline commands
legendecas Nov 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix hoisted karma issue
  • Loading branch information
legendecas committed Nov 1, 2023
commit 08225f148842260356c85b96bbed00b675c703cc
2 changes: 1 addition & 1 deletion .github/workflows/w3c-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
npm ci

- name: Generate version.ts files
run: lerna run version
run: npm run version:update

- name: Build 🔧
run: npm run compile
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
### :house: (Internal)

* chore: track package-lock.json [#4238](https://github.com/open-telemetry/opentelemetry-js/pull/4238) @legendecas
* Switched to npm workspaces to bootstrap dependencies.

## 1.17.1

Expand Down
14 changes: 14 additions & 0 deletions maintenance/npm_workspaces.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Maintaining npm workspaces dependencies

This documents the caveats on maintaining npm workspaces dependencies.

## Karma

Packages with executables are hoisted in workspaces. In this case, `karma` and
its plugins are not installed in the same `node_modules` folder, which leads to
a condition that `karma` can not find the plugins necessary to run the tests.

To alleviate this, karma and its plugins are listed as root dependencies as
well.

Relevant issue: https://github.com/npm/rfcs/issues/287
Loading