Skip to content

feat(resources): implements service.instance.id #4608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 12 commits into from
Apr 15, 2024
Merged

feat(resources): implements service.instance.id #4608

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e38e25a
feat(node-sdk): implements `service.instance.id`
maryliag Apr 5, 2024
b729f0b
implement service instance id by default with env var
maryliag Apr 9, 2024
6b00564
Update CHANGELOG.md
maryliag Apr 10, 2024
7976713
create separate add experimental for browser and node
maryliag Apr 10, 2024
0f96158
use resource detector for service instance id
maryliag Apr 10, 2024
032c660
remove references to env variables
maryliag Apr 10, 2024
f6a0694
remove Detector and use DetectorSync
maryliag Apr 11, 2024
bc7478a
Update packages/opentelemetry-resources/src/platform/node/ServiceInst…
maryliag Apr 11, 2024
78c31e9
rename ServiceInstanceIDDetector to ServiceInstanceIDDetectorSync
maryliag Apr 11, 2024
a6a779f
change ID to Id
maryliag Apr 12, 2024
118e713
renaming something temp so git will pick up the name change
maryliag Apr 12, 2024
54baf54
update to final name using Id
maryliag Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename ServiceInstanceIDDetector to ServiceInstanceIDDetectorSync
  • Loading branch information
@maryliag
maryliag committed Apr 11, 2024
commit 78c31e932b109415b516e24373f3e5f28f7173a8
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
### :rocket: (Enhancement)

* feat(sdk-trace-base): log resource attributes in ConsoleSpanExporter [#4605](https://github.com/open-telemetry/opentelemetry-js/pull/4605) @pichlermarc
* feat(resources): new experimental detector ServiceInstanceIDDetector that sets the value for `service.instance.id` as random UUID.
* feat(resources): new experimental detector ServiceInstanceIDDetectorSync that sets the value for `service.instance.id` as random UUID.

### :bug: (Bug Fix)

Expand Down
4 changes: 2 additions & 2 deletions experimental/packages/opentelemetry-sdk-node/test/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ import {
processDetector,
hostDetector,
Resource,
serviceInstanceIDDetector,
serviceInstanceIDDetectorSync,
Copy link
Contributor

@trentm trentm Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCD nit: In other class names "id" has been capitalized as "Id" rather than "ID":

% rg -I 'export class' | rg ID

% rg -I 'export class' | rg Id
export class TraceIdRatioBasedSampler implements Sampler {
export class RandomIdGenerator implements IdGenerator {
export class RandomIdGenerator implements IdGenerator {
export class TraceIdRatioBasedSampler implements Sampler {
export class RandomIdGenerator implements IdGenerator {
export class RandomIdGenerator implements IdGenerator {

Though, given OSDetectorSync consistency is difficult.

Copy link
Contributor Author

@maryliag maryliag Apr 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCD crisis adverted! 😄 Changed to Id

} from '@opentelemetry/resources';
import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-http';
import { logs } from '@opentelemetry/api-logs';
Expand Down Expand Up @@ -704,7 +704,7 @@ describe('Node SDK', () => {
processDetector,
envDetector,
hostDetector,
serviceInstanceIDDetector,
serviceInstanceIDDetectorSync,
],
});

Expand Down
2 changes: 1 addition & 1 deletion packages/opentelemetry-resources/src/platform/browser/ServiceInstanceIDDetectorSync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ import { noopDetectorSync } from '../../detectors/NoopDetectorSync';
/**
* @experimental
*/
export const serviceInstanceIDDetector = noopDetectorSync;
export const serviceInstanceIDDetectorSync = noopDetectorSync;
3 changes: 2 additions & 1 deletion packages/opentelemetry-resources/src/platform/node/ServiceInstanceIDDetectorSync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,5 @@ class ServiceInstanceIDDetectorSync implements DetectorSync {
/**
* @experimental
*/
export const serviceInstanceIDDetectorSync = new ServiceInstanceIDDetectorSync();
export const serviceInstanceIDDetectorSync =
new ServiceInstanceIDDetectorSync();