Skip to content

feat(scope-zone): new scope manager to support async operations in web #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayurkale22 merged 21 commits into from
Nov 11, 2019
Merged

feat(scope-zone): new scope manager to support async operations in web #461

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
280dfc3
feat(scope-zone): new scope manager to support async operations in web
obecny Oct 25, 2019
67ca355
chore: removing not needed dependency
obecny Oct 25, 2019
9707516
chore: updating readme
obecny Oct 28, 2019
b2b79b8
chore: clean up
obecny Oct 28, 2019
bfa8d7c
chore: refactored the bind method
obecny Oct 28, 2019
21785a3
chore: updated example for web tracer
obecny Oct 28, 2019
d835b9e
chore: updated readme
obecny Oct 28, 2019
dc04370
chore: updating jsdoc
obecny Oct 28, 2019
1855b70
Merge branch 'master' into scope_zone_manager
obecny Oct 28, 2019
290d4af
fix: fixing flaky test for BatchSpanProcessor with timeout
obecny Oct 28, 2019
4050623
chore: missing link
obecny Oct 29, 2019
eb7e03b
Merge branch 'master' into scope_zone_manager
obecny Nov 1, 2019
2e20351
chore: updating karma files
obecny Nov 1, 2019
02e50e6
chore: adding docs and tests for utils
obecny Nov 1, 2019
687048e
chore: refactoring zone scope manager
obecny Nov 1, 2019
9e2e995
chore: adding test for web and zone scope manager for parallel actions
obecny Nov 1, 2019
380a2e7
chore: updating example for web tracer with zone scope manager
obecny Nov 1, 2019
21bf834
chore: updating example for web tracer with zone scope manager
obecny Nov 1, 2019
9782a03
chore: adding test for parallel run
obecny Nov 5, 2019
162a2fd
chore: merge branch 'master' into scope_zone_manager
obecny Nov 5, 2019
e4f20c3
Merge branch 'master' into scope_zone_manager
mayurkale22 Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: clean up
  • Loading branch information
@obecny
obecny committed Oct 28, 2019
commit b2b79b8202e8f46c0a93e5588d998bb2a696a72c
5 changes: 1 addition & 4 deletions packages/opentelemetry-scope-zone-peer-dep/src/ZoneScopeManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ export class ZoneScopeManager implements ScopeManager {
*/
private _zoneCounter = 0;

constructor() {}

/**
* Returns the active scope from certain zone name
* @param activeZoneName
Expand Down Expand Up @@ -176,8 +174,7 @@ export class ZoneScopeManager implements ScopeManager {
private _createZoneName() {
this._zoneCounter++;
const random = Math.random();
const zoneName = `${this._zoneCounter}-${random}`;
return zoneName;
return `${this._zoneCounter}-${random}`;
}

/**
Expand Down