Skip to content

fix(otlp-grpc-exporter-base): avoid TypeError on exporter shutdown #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 7 commits into from
Apr 11, 2024
Merged

fix(otlp-grpc-exporter-base): avoid TypeError on exporter shutdown #4612

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5e33a1
fix(otlp-grpc-exporter-base): avoid TypeError on exporter shutdown
pichlermarc Apr 8, 2024
e27fb4f
chore: update changelog
pichlermarc Apr 8, 2024
ced6e33
Merge branch 'main' into fix/grpc-exporter-transport-shutdown
pichlermarc Apr 10, 2024
b4dbd93
fix: use gRPC Client type over any
pichlermarc Apr 11, 2024
c36f785
fixup! fix: use gRPC Client type over any
pichlermarc Apr 11, 2024
2987757
Merge branch 'main' into fix/grpc-exporter-transport-shutdown
pichlermarc Apr 11, 2024
971d215
fix: use ts-lint/ts-ignore
pichlermarc Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fix: use gRPC Client type over any
  • Loading branch information
@pichlermarc
pichlermarc committed Apr 11, 2024
commit c36f785068385471042bf3ba70931fae3cbbd25c
3 changes: 2 additions & 1 deletion experimental/packages/otlp-grpc-exporter-base/src/grpc-exporter-transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@ export class GrpcExporterTransport implements IExporterTransport {
});
}

// Using `any` as the gRPC client constructor is created on runtime, so we don't have any types for it.
// Using `any` as the gRPC client constructor is created on runtime,
// so we don't have any types for the resulting client.
(this._client as any).export(
buffer,
this._metadata,
Expand Down