fix(resources): prevent circular import (resource -> detector -> resource -> ...) #4653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
approved these changes
Apr 24, 2024
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
May 6, 2024
…urce -> ...) (open-telemetry#4653) * fix(resources): prevent circular import (resource -> detector -> resource -> ...) * fixup! fix(resources): prevent circular import (resource -> detector -> resource -> ...)
pichlermarc
added a commit
that referenced
this pull request
May 15, 2024
…ents (#4705) * fix(resources): prevent circular import (resource -> detector -> resource -> ...) (#4653) * fix(resources): prevent circular import (resource -> detector -> resource -> ...) * fixup! fix(resources): prevent circular import (resource -> detector -> resource -> ...) * fix(core): align inconsistent behavior of getEnv() and getEnvWithoutDefaults() when a process polyfill is used (#4649) * fix(core): align inconsistent behavior of getEnv() and getEnvWithoutDefaults() when a process polyfill is used * Update CHANGELOG.md * fix(deps): update dependency import-in-the-middle to v1.7.4 (#4667) * fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base depen… (#4678) * fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base dependency to exporter-metrics-otlp-grpc * Update CHANGELOG.md --------- Co-authored-by: Marc Pichler <[email protected]> * chore: sync package-lock.json, adapt changelog * chore: prepare release 1.24.1/0.51.1 * chore: adjust changelog * chore: sync package-lock.json --------- Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Aksel Allas <[email protected]>
This was referenced Jun 21, 2024
This was referenced Jun 27, 2024
Merged
This was referenced Sep 12, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…urce -> ...) (open-telemetry#4653) * fix(resources): prevent circular import (resource -> detector -> resource -> ...) * fixup! fix(resources): prevent circular import (resource -> detector -> resource -> ...)
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…ents (open-telemetry#4705) * fix(resources): prevent circular import (resource -> detector -> resource -> ...) (open-telemetry#4653) * fix(resources): prevent circular import (resource -> detector -> resource -> ...) * fixup! fix(resources): prevent circular import (resource -> detector -> resource -> ...) * fix(core): align inconsistent behavior of getEnv() and getEnvWithoutDefaults() when a process polyfill is used (open-telemetry#4649) * fix(core): align inconsistent behavior of getEnv() and getEnvWithoutDefaults() when a process polyfill is used * Update CHANGELOG.md * fix(deps): update dependency import-in-the-middle to v1.7.4 (open-telemetry#4667) * fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base depen… (open-telemetry#4678) * fix(exporter-metrics-otlp-grpc) Add explicit otlp-exporter-base dependency to exporter-metrics-otlp-grpc * Update CHANGELOG.md --------- Co-authored-by: Marc Pichler <[email protected]> * chore: sync package-lock.json, adapt changelog * chore: prepare release 1.24.1/0.51.1 * chore: adjust changelog * chore: sync package-lock.json --------- Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Aksel Allas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Using
@opentelemetry/resourceswithrollupcauses a warning to be logged:Fixes #4452
Short description of the changes
Resourcedoes not import detectors anymore (moved detectors to the detectors directory)Type of change
How Has This Been Tested?
rollup