Skip to content

chore: fixing coverage for karma using istanbul#466

Merged
mayurkale22 merged 2 commits intoopen-telemetry:masterfrom
obecny:karma-tests-fix
Nov 1, 2019
Merged

chore: fixing coverage for karma using istanbul#466
mayurkale22 merged 2 commits intoopen-telemetry:masterfrom
obecny:karma-tests-fix

Conversation

@obecny
Copy link
Member

@obecny obecny commented Oct 30, 2019

Which problem is this PR solving?

  1. Fixes Fix karma coverage for browsers tests #455

Short description of the changes

Fixing coverage tests with karma

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (173cab2) to head (f425bc8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
+ Coverage   95.06%   95.30%   +0.24%     
==========================================
  Files         132      136       +4     
  Lines        6782     6926     +144     
  Branches      568      597      +29     
==========================================
+ Hits         6447     6601     +154     
+ Misses        335      325      -10     

see 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mayurkale22 mayurkale22 merged commit ae904d5 into open-telemetry:master Nov 1, 2019
@obecny obecny deleted the karma-tests-fix branch July 8, 2020 12:15
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix karma coverage for browsers tests

8 participants