refactor(examples/esm-http-ts): use new exported string constants for semconv #4758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieDanielson
approved these changes
Jun 4, 2024
Member
JamieDanielson
left a comment
JamieDanielson
left a comment
There was a problem hiding this comment.
Can you please add a changelog entry? I'm not sure why the Node14 test is failing, perhaps it is flaky and will pass on the next commit. Will take a look if it fails again.
24 tasks
pichlermarc
reviewed
Jun 5, 2024
pichlermarc
approved these changes
Jun 5, 2024
pichlermarc
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
This was referenced Jun 27, 2024
Merged
This was referenced Jul 17, 2024
This was referenced Sep 12, 2024
Open
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
… semconv (open-telemetry#4758) * refactor(examples/ems-http-ts): use new exported string constants for semconv * added changelog entry * Update CHANGELOG.md --------- Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Updates #4567
Short description of the changes
Replaced deprecated import (SemanticResourceAttributes) from @opentelemetry/semantic-conventions with new string constants (SEMRESATTRS_SERVICE_NAME) for the example
esm-http-tspackageType of change
How Has This Been Tested?
Checklist: