Semconv entrypoints #4770
Closed
Semconv entrypoints #4770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryliag
reviewed
Jun 10, 2024
|
|
||
| # Run the size checks for the generated files | ||
| cd "${ROOT_DIR}/packages/opentelemetry-semantic-conventions" | ||
| npm run size-check |
Contributor
There was a problem hiding this comment.
curious why this was removed. If indeed not required anymore, the comment above needs to be updated
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to explore using entrypoints for explicit version imports of semconv
Changes:
1.7dirindexexport entries explaining that you should import a version directlyFuture changes:
Importing from the default import is deprecated
Importing 1.7 entrypoint is unchanged from previous
