fix(sdk-node): register context manager if no tracer options are provided #4781
+22
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-luna
approved these changes
Jun 10, 2024
maryliag
approved these changes
Jun 10, 2024
This was referenced Jul 12, 2024
Closed
Closed
Zirak
pushed a commit
to Zirak/opentelemetry-js
that referenced
this pull request
Sep 14, 2024
…ided (open-telemetry#4781) * fix(sdk-node): register context manager if no tracer options are provided * chore: add changelog entry
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Context managers were not properly registered when no trace-releated options were passed to the NodeSDK constructor.
Fixes #4776
Short description of the changes
Falls back to the raw
contextManageroption in case the tracer options are undefined.Type of change
How Has This Been Tested?