Skip to content

feat(otlp-transformer): Do not limit @opentelemetry/api upper range peerDependency #4816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 5 commits into from
Jul 30, 2024
Merged

feat(otlp-transformer): Do not limit @opentelemetry/api upper range peerDependency #4816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0dd3d5
feat: Do not limit `@opentelemetry/api` upper range peerDependency
mydea Jun 21, 2024
69cc5fa
Revert "feat: Do not limit `@opentelemetry/api` upper range peerDepen…
mydea Jun 26, 2024
d2e8b8f
only unclamp otlp-transformer
mydea Jun 26, 2024
551c496
Add changelog entry
mydea Jul 1, 2024
885a657
Merge branch 'main' into fn/no-limit-peer-dep
pichlermarc Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ All notable changes to experimental packages in this project will be documented

### :rocket: (Enhancement)

* feat(otlp-transformer): Do not limit @opentelemetry/api upper range peerDependency [#4816](https://github.com/open-telemetry/opentelemetry-js/pull/4816) @mydea
* feat(instrumentation-http): Allow to opt-out of instrumenting incoming/outgoing requests [#4643](https://github.com/open-telemetry/opentelemetry-js/pull/4643) @mydea

### :bug: (Bug Fix)
Expand Down
2 changes: 1 addition & 1 deletion experimental/packages/otlp-transformer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"README.md"
],
"peerDependencies": {
"@opentelemetry/api": ">=1.3.0 <1.10.0"
"@opentelemetry/api": "^1.3.0"
Copy link
Member

@pichlermarc pichlermarc Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This here is fine to unpin as it does not implement the API. 👍

Copy link
Contributor Author

@mydea mydea Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think I kind of get it now. Took me some time and iterations to really wrap my head around this. I think what confused me additionally is that this package here had this (which, as you stated, does not need it), which is also how we stumbled over this problem in the first place. So I'll just fix this one place instead! 👍

},
"devDependencies": {
"@opentelemetry/api": "1.9.0",
Expand Down