Skip to content

fix(instrumentation): Fix optional property types #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legendecas merged 1 commit into from
Aug 15, 2024
Merged

fix(instrumentation): Fix optional property types #4833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/

* fix(sdk-node): avoid spurious diag errors for unknown OTEL_NODE_RESOURCE_DETECTORS values [#4879](https://github.com/open-telemetry/opentelemetry-js/pull/4879) @trentm
* deps(opentelemetry-instrumentation): Bump `shimmer` types to 1.2.0 [#4865](https://github.com/open-telemetry/opentelemetry-js/pull/4865) @lforst
* fix(instrumentation): Fix optional property types [#4833](https://github.com/open-telemetry/opentelemetry-js/pull/4833) @alecmev

### :books: (Refine Doc)

Expand Down
8 changes: 6 additions & 2 deletions experimental/packages/opentelemetry-instrumentation/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,15 @@ export interface InstrumentationModuleDefinition {

/** Method to patch the instrumentation */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
patch?: (moduleExports: any, moduleVersion?: string) => any;
patch?:
| ((moduleExports: any, moduleVersion?: string | undefined) => any)
| undefined;

/** Method to unpatch the instrumentation */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
unpatch?: (moduleExports: any, moduleVersion?: string) => void;
unpatch?:
| ((moduleExports: any, moduleVersion?: string | undefined) => void)
| undefined;
}

/**
Expand Down