Skip to content

fix(instrumentation-http): Ensure instrumentation of http.get and https.get work when used in ESM code #4866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trentm merged 11 commits into from
Jul 24, 2024
Merged

fix(instrumentation-http): Ensure instrumentation of http.get and https.get work when used in ESM code #4866

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1563f93
fix(instrumentation-http): Ensure instrumentation of `http.get` and `…
trentm Jul 15, 2024
4eb8607
correct typo in the changelog message
trentm Jul 15, 2024
94933d6
does this fix the test:esm script running on windows?
trentm Jul 15, 2024
942aa19
remove other console.logs (presumably dev leftovers) from tests in th…
trentm Jul 17, 2024
28a81e7
Merge branch 'main' into tm-fix-esm-http.get
trentm Jul 17, 2024
ed68ff7
test name suggestion
trentm Jul 24, 2024
5a40e94
test name suggestion
trentm Jul 24, 2024
4ff3771
test name suggestion
trentm Jul 24, 2024
71811c4
test name suggestion
trentm Jul 24, 2024
8eb6c7d
var naming suggestion: expand cres and creq, the abbrev isn't obvious
trentm Jul 24, 2024
011af25
Merge branch 'main' into tm-fix-esm-http.get
trentm Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test name suggestion 
Co-authored-by: Jamie Danielson <jamieedanielson@gmail.com>
  • Loading branch information
@trentm @JamieDanielson
trentm and JamieDanielson authored Jul 24, 2024
commit 4ff377160b6e935fe933710d6bfd4ab543f9e123
2 changes: 1 addition & 1 deletion experimental/packages/opentelemetry-instrumentation-http/test/integrations/esm.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ describe('HttpInstrumentation ESM Integration tests', () => {
assertSpan(span, SpanKind.CLIENT, spanValidations);
});

it('http.get', async () => {
it('should instrument http requests using http.get', async () => {
const spanValidations = {
httpStatusCode: 200,
httpMethod: 'GET',
Expand Down