Skip to content

fix(instrumentation): drop diag.debug on InstrumentationBase#init not returning any modules #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 3 commits into from
Aug 19, 2024
+1 −8
Merged

fix(instrumentation): drop diag.debug on InstrumentationBase#init not returning any modules #4925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91fccf1
fix(instrumentation): drop diag.debug on InstrumentationBase#init not…
trentm Aug 15, 2024
d4a95c8
Merge branch 'main' into tm-drop-no-modules-diag-debug
trentm Aug 15, 2024
ae8f4a6
chagnelog entry
trentm Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ All notable changes to experimental packages in this project will be documented

* fix(instrumentation-http): Ensure instrumentation of `http.get` and `https.get` work when used in ESM code [#4857](https://github.com/open-telemetry/opentelemetry-js/issues/4857) @trentm
* fix(api-logs): align AnyValue to spec [#4893](https://github.com/open-telemetry/opentelemetry-js/pull/4893) @blumamir
* fix(instrumentation): remove diag.debug() message for instrumentations that do not patch modules [#4925](https://github.com/open-telemetry/opentelemetry-js/pull/4925) @trentm

### :books: (Refine Doc)

Expand Down
8 changes: 0 additions & 8 deletions experimental/packages/opentelemetry-instrumentation/src/platform/node/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,6 @@ export abstract class InstrumentationBase<

this._modules = (modules as InstrumentationModuleDefinition[]) || [];

if (this._modules.length === 0) {
diag.debug(
'No modules instrumentation has been defined for ' +
`'${this.instrumentationName}@${this.instrumentationVersion}'` +
', nothing will be patched'
);
}

if (this._config.enabled) {
this.enable();
}
Expand Down