[draft] feat(sdk-metrics)!: use factory functions over classes

doc/metrics.md

@@ -543,7 +543,7 @@ const collectorOptions = {
 const exporter = new OTLPMetricExporter(collectorOptions);
 const meterProvider = new MeterProvider({});
 
-meterProvider.addMetricReader(new PeriodicExportingMetricReader({
+meterProvider.addMetricReader(createPeriodicExportingMetricReader({
   exporter: metricExporter,
   exportIntervalMillis: 1000,
 }));

examples/opentelemetry-web/examples/metrics/index.js

@@ -21,7 +21,7 @@ function startMetrics() {
   const meterProvider = new MeterProvider();
   metrics.setGlobalMeterProvider(meterProvider);
 
-  meterProvider.addMetricReader(new PeriodicExportingMetricReader({
+  meterProvider.addMetricReader(createPeriodicExportingMetricReader({
     exporter: new OTLPMetricExporter(),
     exportIntervalMillis: 1000
   }));

examples/otlp-exporter-node/metrics.js

@@ -42,7 +42,7 @@ const meterProvider = new MeterProvider({
 });
 
 meterProvider.addMetricReader(
-  new PeriodicExportingMetricReader({
+  createPeriodicExportingMetricReader({
     exporter: metricExporter,
     // exporter: new ConsoleMetricExporter(),
     exportIntervalMillis: 1000,

experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/README.md

@@ -38,7 +38,7 @@ const collectorOptions = {
 const metricExporter = new OTLPMetricExporter(collectorOptions);
 const meterProvider = new MeterProvider({});
 
-meterProvider.addMetricReader(new PeriodicExportingMetricReader({
+meterProvider.addMetricReader(createPeriodicExportingMetricReader({
   exporter: metricExporter,
   exportIntervalMillis: 1000,
 }));

experimental/packages/opentelemetry-exporter-metrics-otlp-grpc/test/metricsHelper.ts

@@ -28,7 +28,7 @@ import * as grpc from '@grpc/grpc-js';
 import { VERSION } from '@opentelemetry/core';
 import {
   AggregationType,
-  MeterProvider,
+  createMeterProvider,
   MetricReader,
 } from '@opentelemetry/sdk-metrics';
 import {
@@ -55,7 +55,7 @@ const testResource = new Resource({
 });
 
 let reader = new TestMetricReader();
-let meterProvider = new MeterProvider({
+let meterProvider = createMeterProvider({
   resource: testResource,
   readers: [reader],
 });
@@ -68,7 +68,7 @@ export async function collect() {
 
 export function setUp() {
   reader = new TestMetricReader();
-  meterProvider = new MeterProvider({
+  meterProvider = createMeterProvider({
     resource: testResource,
     views: [
       {

experimental/packages/opentelemetry-exporter-metrics-otlp-http/README.md

@@ -37,7 +37,7 @@ const collectorOptions = {
 const metricExporter = new OTLPMetricExporter(collectorOptions);
 const meterProvider = new MeterProvider({});
 
-meterProvider.addMetricReader(new PeriodicExportingMetricReader({
+meterProvider.addMetricReader(createPeriodicExportingMetricReader({
   exporter: metricExporter,
   exportIntervalMillis: 1000,
 }));
@@ -60,7 +60,7 @@ const collectorOptions = {
 const metricExporter = new OTLPMetricExporter(collectorOptions);
 const meterProvider = new MeterProvider({});
 
-meterProvider.addMetricReader(new PeriodicExportingMetricReader({
+meterProvider.addMetricReader(createPeriodicExportingMetricReader({
   exporter: metricExporter,
   exportIntervalMillis: 1000,
 }));

experimental/packages/opentelemetry-exporter-metrics-otlp-http/test/metricsHelper.ts

@@ -29,7 +29,7 @@ import * as assert from 'assert';
 import { InstrumentationScope, VERSION } from '@opentelemetry/core';
 import {
   AggregationType,
-  MeterProvider,
+  createMeterProvider,
   MetricReader,
   ViewOptions,
 } from '@opentelemetry/sdk-metrics';
@@ -78,7 +78,7 @@ const defaultResource = Resource.default().merge(
 );
 
 let reader = new TestMetricReader();
-let meterProvider = new MeterProvider({
+let meterProvider = createMeterProvider({
   resource: defaultResource,
   readers: [reader],
 });
@@ -90,7 +90,7 @@ export async function collect() {
 
 export function setUp(views?: ViewOptions[]) {
   reader = new TestMetricReader();
-  meterProvider = new MeterProvider({
+  meterProvider = createMeterProvider({
     resource: defaultResource,
     views,
     readers: [reader],

experimental/packages/opentelemetry-exporter-metrics-otlp-proto/README.md

@@ -30,7 +30,7 @@ const collectorOptions = {
 const metricExporter = new OTLPMetricExporter(collectorOptions);
 const meterProvider = new MeterProvider({});
 
-meterProvider.addMetricReader(new PeriodicExportingMetricReader({
+meterProvider.addMetricReader(createPeriodicExportingMetricReader({
   exporter: metricExporter,
   exportIntervalMillis: 1000,
 }));

experimental/packages/opentelemetry-exporter-metrics-otlp-proto/test/metricsHelper.ts

@@ -26,7 +26,7 @@ import { Resource } from '@opentelemetry/resources';
 import * as assert from 'assert';
 import {
   AggregationType,
-  MeterProvider,
+  createMeterProvider,
   MetricReader,
 } from '@opentelemetry/sdk-metrics';
 import {
@@ -54,7 +54,7 @@ const testResource = new Resource({
 });
 
 let reader = new TestMetricReader();
-let meterProvider = new MeterProvider({
+let meterProvider = createMeterProvider({
   resource: testResource,
   readers: [reader],
 });
@@ -67,7 +67,7 @@ export async function collect() {
 
 export function setUp() {
   reader = new TestMetricReader();
-  meterProvider = new MeterProvider({
+  meterProvider = createMeterProvider({
     resource: testResource,
     views: [
       {

experimental/packages/opentelemetry-exporter-prometheus/test/PrometheusExporter.test.ts

@@ -14,8 +14,13 @@
  * limitations under the License.
  */
 
-import { Counter, Meter, ObservableResult } from '@opentelemetry/api';
-import { MeterProvider } from '@opentelemetry/sdk-metrics';
+import {
+  Counter,
+  Meter,
+  MeterProvider,
+  ObservableResult,
+} from '@opentelemetry/api';
+import { createMeterProvider } from '@opentelemetry/sdk-metrics';
 import * as assert from 'assert';
 import * as sinon from 'sinon';
 import * as http from 'http';
@@ -200,12 +205,12 @@ describe('PrometheusExporter', () => {
 
   describe('export', () => {
     let exporter: PrometheusExporter;
-    let meterProvider: MeterProvider;
+    let meterProvider: ReturnType<typeof createMeterProvider>;
     let meter: Meter;
 
     beforeEach(async () => {
       exporter = new PrometheusExporter();
-      meterProvider = new MeterProvider({
+      meterProvider = createMeterProvider({
         readers: [exporter],
       });
       meter = meterProvider.getMeter('test-prometheus', '1');
@@ -471,7 +476,7 @@ describe('PrometheusExporter', () => {
     let exporter: PrometheusExporter;
 
     function setup(reader: PrometheusExporter) {
-      meterProvider = new MeterProvider({
+      meterProvider = createMeterProvider({
         readers: [exporter],
       });
 

experimental/packages/opentelemetry-exporter-prometheus/test/PrometheusSerializer.test.ts

@@ -18,10 +18,10 @@ import * as assert from 'assert';
 import { MetricAttributes, UpDownCounter } from '@opentelemetry/api';
 import {
   AggregationTemporality,
+  createMeterProvider,
   DataPoint,
   DataPointType,
   Histogram,
-  MeterProvider,
   MetricReader,
 } from '@opentelemetry/sdk-metrics';
 import * as sinon from 'sinon';
@@ -82,7 +82,7 @@ describe('PrometheusSerializer', () => {
     describe('Singular', () => {
       async function testSerializer(serializer: PrometheusSerializer) {
         const reader = new TestMetricReader();
-        const meterProvider = new MeterProvider({
+        const meterProvider = createMeterProvider({
           views: [
             {
               aggregation: { type: AggregationType.SUM },
@@ -132,7 +132,7 @@ describe('PrometheusSerializer', () => {
     describe('Histogram', () => {
       async function testSerializer(serializer: PrometheusSerializer) {
         const reader = new TestMetricReader();
-        const meterProvider = new MeterProvider({
+        const meterProvider = createMeterProvider({
           views: [
             {
               aggregation: {
@@ -202,7 +202,7 @@ describe('PrometheusSerializer', () => {
     describe('monotonic Sum', () => {
       async function testSerializer(serializer: PrometheusSerializer) {
         const reader = new TestMetricReader();
-        const meterProvider = new MeterProvider({
+        const meterProvider = createMeterProvider({
           views: [
             {
               aggregation: { type: AggregationType.SUM },
@@ -257,7 +257,7 @@ describe('PrometheusSerializer', () => {
     describe('non-monotonic Sum', () => {
       async function testSerializer(serializer: PrometheusSerializer) {
         const reader = new TestMetricReader();
-        const meterProvider = new MeterProvider({
+        const meterProvider = createMeterProvider({
           views: [
             {
               aggregation: { type: AggregationType.SUM },
@@ -311,7 +311,7 @@ describe('PrometheusSerializer', () => {
     describe('Gauge', () => {
       async function testSerializer(serializer: PrometheusSerializer) {
         const reader = new TestMetricReader();
-        const meterProvider = new MeterProvider({
+        const meterProvider = createMeterProvider({
           views: [
             {
               aggregation: {
@@ -367,7 +367,7 @@ describe('PrometheusSerializer', () => {
     describe('with ExplicitBucketHistogramAggregation', () => {
       async function testSerializer(serializer: PrometheusSerializer) {
         const reader = new TestMetricReader();
-        const meterProvider = new MeterProvider({
+        const meterProvider = createMeterProvider({
           views: [
             {
               aggregation: {
@@ -425,7 +425,7 @@ describe('PrometheusSerializer', () => {
       it('serialize cumulative metric record on instrument that allows negative values', async () => {
         const serializer = new PrometheusSerializer();
         const reader = new TestMetricReader();
-        const meterProvider = new MeterProvider({
+        const meterProvider = createMeterProvider({
           views: [
             {
               aggregation: {
@@ -481,7 +481,7 @@ describe('PrometheusSerializer', () => {
       options: Partial<{ unit: string; exportAll: boolean }> = {}
     ) {
       const reader = new TestMetricReader();
-      const meterProvider = new MeterProvider({
+      const meterProvider = createMeterProvider({
         views: [
           {
             aggregation: { type: AggregationType.SUM },
@@ -573,7 +573,7 @@ describe('PrometheusSerializer', () => {
       fn: (counter: UpDownCounter) => void
     ) {
       const reader = new TestMetricReader();
-      const meterProvider = new MeterProvider({
+      const meterProvider = createMeterProvider({
         views: [
           {
             aggregation: { type: AggregationType.SUM },

experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-metrics.test.ts

@@ -15,9 +15,9 @@
  */
 import {
   AggregationTemporality,
+  createInMemoryMetricExporter,
+  createMeterProvider,
   DataPointType,
-  InMemoryMetricExporter,
-  MeterProvider,
 } from '@opentelemetry/sdk-metrics';
 import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import {
@@ -47,11 +47,11 @@ const protocol = 'http';
 const hostname = 'localhost';
 const pathname = '/test';
 const tracerProvider = new NodeTracerProvider();
-const metricsMemoryExporter = new InMemoryMetricExporter(
-  AggregationTemporality.DELTA
-);
+const metricsMemoryExporter = createInMemoryMetricExporter({
+  aggregationTemporality: AggregationTemporality.DELTA,
+});
 const metricReader = new TestMetricReader(metricsMemoryExporter);
-const meterProvider = new MeterProvider({ readers: [metricReader] });
+const meterProvider = createMeterProvider({ readers: [metricReader] });
 
 instrumentation.setTracerProvider(tracerProvider);
 instrumentation.setMeterProvider(meterProvider);

experimental/packages/opentelemetry-instrumentation/test/common/Instrumentation.test.ts

@@ -23,8 +23,9 @@ import {
   SpanCustomizationHook,
 } from '../../src';
 
-import { MeterProvider } from '@opentelemetry/sdk-metrics';
+import { createMeterProvider } from '@opentelemetry/sdk-metrics';
 import { LoggerProvider } from '@opentelemetry/sdk-logs';
+import { MeterProvider } from '@opentelemetry/api';
 
 interface TestInstrumentationConfig extends InstrumentationConfig {
   isActive?: boolean;
@@ -84,7 +85,7 @@ describe('BaseInstrumentation', () => {
   describe('setMeterProvider', () => {
     let otelTestingMeterProvider: MeterProvider;
     beforeEach(() => {
-      otelTestingMeterProvider = new MeterProvider();
+      otelTestingMeterProvider = createMeterProvider();
     });
     it('should call _updateMetricInstruments', () => {
       let called = true;

experimental/packages/opentelemetry-sdk-node/src/sdk.ts

@@ -39,7 +39,7 @@ import {
 } from '@opentelemetry/resources';
 import { LogRecordProcessor, LoggerProvider } from '@opentelemetry/sdk-logs';
 import {
-  MeterProvider,
+  createMeterProvider,
   MetricReader,
   ViewOptions,
 } from '@opentelemetry/sdk-metrics';
@@ -95,7 +95,7 @@ export class NodeSDK {
 
   private _tracerProvider?: NodeTracerProvider | TracerProviderWithEnvExporters;
   private _loggerProvider?: LoggerProvider;
-  private _meterProvider?: MeterProvider;
+  private _meterProvider?: ReturnType<typeof createMeterProvider>;
   private _serviceName?: string;
   private _configuration?: Partial<NodeSDKConfiguration>;
 
@@ -275,7 +275,7 @@ export class NodeSDK {
       if (this._meterProviderConfig.reader) {
         readers.push(this._meterProviderConfig.reader);
       }
-      const meterProvider = new MeterProvider({
+      const meterProvider = createMeterProvider({
         resource: this._resource,
         views: this._meterProviderConfig?.views ?? [],
         readers: readers,