Skip to content

Conversation

@pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Aug 28, 2024

Supersedes #4958 .

Types are incorrect not only on memfs but also unionfs. The additional commit b4c9a96 applies the workaround from webpack/webpack#18242 (comment)

@pichlermarc pichlermarc requested a review from a team August 28, 2024 12:33
@pichlermarc pichlermarc added the dependencies Pull requests that update a dependency file label Aug 28, 2024
@pichlermarc pichlermarc force-pushed the renovate/npm-webpack-vulnerability branch from 18f41e1 to b4c9a96 Compare August 28, 2024 12:41
Comment on lines +91 to +93
// direct webpack to use unionfs for file input
// needs workaround from https://github.com/webpack/webpack/issues/18242#issuecomment-2018116985 since webpack 5.91.0
compiler.inputFileSystem = fs as any as typeof compiler.inputFileSystem;
Copy link
Member Author

@pichlermarc pichlermarc Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewer note: this is the only code-change I made, the rest is package.json updates.

@pichlermarc pichlermarc added this pull request to the merge queue Aug 28, 2024
Merged via the queue into open-telemetry:main with commit d7f4288 Aug 28, 2024
@pichlermarc pichlermarc deleted the renovate/npm-webpack-vulnerability branch August 28, 2024 13:04
dyladan pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Sep 4, 2024
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants