feat(sdk-trace-base): replace SpanAttributes with Attributes#5009
Merged
pichlermarc merged 5 commits intoopen-telemetry:nextfrom Sep 25, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5009 +/- ##
==========================================
- Coverage 93.96% 93.94% -0.02%
==========================================
Files 310 310
Lines 8147 8147
Branches 1630 1630
==========================================
- Hits 7655 7654 -1
- Misses 492 493 +1
|
pichlermarc
reviewed
Sep 24, 2024
5 tasks
pichlermarc
approved these changes
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Replaces
SpanAttributeswithAttributesRefs #4175
Short description of the changes
Replace the interfaces in sources & tests. This PR targeting
nextsince the version bump of@opentelemetry/apipackage makes it a breaking change.How Has This Been Tested?
Ran the test suite for the SDK trace base.