Skip to content

fix(instrumentation-http)!: drop url.parse in favor of URL constructor #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 10 commits into from
Nov 8, 2024
Merged

fix(instrumentation-http)!: drop url.parse in favor of URL constructor #5091

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
db413ee
fix(instrumentation-http): drop url.parse in favor of URL constructor
pichlermarc Oct 22, 2024
2df4ee1
fixup! fix(instrumentation-http): drop url.parse in favor of URL cons…
pichlermarc Oct 25, 2024
a88ef32
fixup! fix(instrumentation-http): drop url.parse in favor of URL cons…
pichlermarc Oct 25, 2024
64c6b12
chore: add changelog entry
pichlermarc Oct 25, 2024
b0d1c8c
chore: update changelog
pichlermarc Nov 5, 2024
9f9e972
refactor(instrumentation-http): pass instrumentation's logger to utils
pichlermarc Nov 5, 2024
4c5825c
fix(instrumentation-http)!: verbose log if URL passed to http request…
pichlermarc Nov 6, 2024
b4f4804
Merge branch 'main' into fix/non-ascii-requests
pichlermarc Nov 6, 2024
768fdff
chore: update changelog to reflect breaking change in getRequestInfo(…
pichlermarc Nov 6, 2024
601c64a
Merge branch 'main' into fix/non-ascii-requests
pichlermarc Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add changelog entry
  • Loading branch information
@pichlermarc
pichlermarc committed Oct 25, 2024
commit 64c6b12c57c7551ca7640de6869d3b0c6e98cb1e
3 changes: 3 additions & 0 deletions experimental/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ All notable changes to experimental packages in this project will be documented

### :bug: (Bug Fix)

* fix(instrumentation-http): drop url.parse in favor of URL constructor [#5091](https://github.com/open-telemetry/opentelemetry-js/pull/5091) @pichlermarc
* fixes a bug where using cyrillic characters in a client request string URL would throw

### :books: (Refine Doc)

### :house: (Internal)
Expand Down