fix: fix #5101 by checking if destroyed

[dermasmid]

Which problem is this PR solving?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #5101

Short description of the changes

check if destroyed before calling destroy

Type of change

Please delete options that are not relevant.

• [*] Bug fix (non-breaking change which fixes an issue)

[linux-foundation-easycla]

• ✅login: dermasmid / (f38e639)

The committers listed above are authorized under a signed CLA.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.16%. Comparing base (eb3ca4f) to head (f38e639).
Report is 44 commits behind head on main.

Files with missing lines	Patch %	Lines
...ter-base/src/platform/node/http-transport-utils.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5102      +/-   ##
==========================================
- Coverage   93.18%   93.16%   -0.03%     
==========================================
  Files         315      315              
  Lines        8086     8088       +2     
  Branches     1617     1618       +1     
==========================================
  Hits         7535     7535              
- Misses        551      553       +2     

Files with missing lines	Coverage Δ
...ter-base/src/platform/node/http-transport-utils.ts	96.00% <50.00%> (-1.92%)	⬇️

... and 1 file with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[pichlermarc]

Thanks for working on a fix for this - is there any way to hit this code-path in a test? 🤔
Without a test it's unfortunately difficult to grasp if this fix is effective.

Maybe I'm wrong, but shouldn't the error handler below ensure that no error is unhandled for the req? Could it be that the error is actually somewhere in compressAndSend() (seeing that the error is EPIPE in the #5101) 🤔

[pichlermarc]

@dermasmid thanks for reporting this over at #5101 🙂

I believe that this should be fixed by #5163 (adding an error handler when piping the serialized message to the request). That fix is in the latest release of the exporter. If the issue still persists please open a new issue so that it comes up in our triage process. Thanks!