fix: zipkin-exporter: don't export after shutdown#526
Merged
mayurkale22 merged 4 commits intoopen-telemetry:masterfrom Nov 19, 2019
Merged
Conversation
2f0ea0b to
b9a35bd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 92.40% 92.33% -0.08%
==========================================
Files 146 146
Lines 7138 7080 -58
Branches 628 630 +2
==========================================
- Hits 6596 6537 -59
- Misses 542 543 +1
🚀 New features to boost your workflow:
|
b9a35bd to
516d86a
Compare
According to spec and exporter should return FailedNotRetryable error after shutdown was called.
516d86a to
cb5d416
Compare
draffensperger
approved these changes
Nov 13, 2019
mayurkale22
approved these changes
Nov 14, 2019
Member
mayurkale22
left a comment
There was a problem hiding this comment.
Looks like same thing needs to be implemented for Jaeger exporter.
Member
Author
|
Seems we have an issue with the just released node type definitions (DefinitelyTyped/DefinitelyTyped#40118): |
OlivierAlbertini
approved these changes
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
According to spec and exporter should return
FailedNotRetryableerrorafter shutdown was called.
see https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-tracing.md#shutdown-1
Short description of the changes
Remember that
shutdown()was called and if yes immediate call callback with error.