Skip to content

Conversation

@pichlermarc
Copy link
Member

Which problem is this PR solving?

Removes deprecated type InstrumentationLibrary, renames InstrumentationLibrary -> InstrumentationScope

Fixes #2937

@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone Jan 9, 2025
@pichlermarc pichlermarc requested a review from a team as a code owner January 9, 2025 10:17
@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (c408d21) to head (92aaa64).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5308      +/-   ##
==========================================
+ Coverage   94.62%   94.63%   +0.01%     
==========================================
  Files         323      323              
  Lines        8071     8071              
  Branches     1640     1640              
==========================================
+ Hits         7637     7638       +1     
+ Misses        434      433       -1     
Files with missing lines Coverage Δ
...al/packages/otlp-transformer/src/trace/internal.ts 98.38% <100.00%> (ø)
...ges/opentelemetry-exporter-jaeger/src/transform.ts 93.33% <100.00%> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts 97.60% <100.00%> (ø)
...ackages/opentelemetry-sdk-trace-base/src/Tracer.ts 98.55% <100.00%> (ø)
...y-sdk-trace-base/src/export/ConsoleSpanExporter.ts 82.35% <ø> (ø)

... and 1 file with indirect coverage changes

@pichlermarc pichlermarc added the target:next-major-release This PR targets the next major release (`next` branch) label Jan 9, 2025
@pichlermarc pichlermarc added this pull request to the merge queue Jan 10, 2025
Merged via the queue into open-telemetry:main with commit 4a6021a Jan 10, 2025
15 checks passed
@pichlermarc pichlermarc deleted the refactor/rename-instrumentation-scope branch January 10, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

target:next-major-release This PR targets the next major release (`next` branch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename InstrumentationLibrary -> InstrumentationScope

2 participants