Skip to content

Conversation

@pichlermarc
Copy link
Member

Which problem is this PR solving?

Migrates away from getEnv() to the new functions and inline-defaults introduced in #5443. Since the Jaeger Exporter was only used in Node.js, everything stays as-is for the end-user. This is a pure refactor.

Refs #5217

Type of change

  • refactor

How Has This Been Tested?

  • Unit tests

@pichlermarc pichlermarc added the target:next-major-release This PR targets the next major release (`next` branch) label Feb 13, 2025
@pichlermarc pichlermarc added this to the OpenTelemetry SDK 2.0 milestone Feb 13, 2025
@pichlermarc pichlermarc requested a review from a team as a code owner February 13, 2025 09:17
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (7438735) to head (8054d35).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5464   +/-   ##
=======================================
  Coverage   94.90%   94.91%           
=======================================
  Files         308      308           
  Lines        7971     7977    +6     
  Branches     1677     1682    +5     
=======================================
+ Hits         7565     7571    +6     
  Misses        406      406           
Files with missing lines Coverage Δ
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 95.40% <100.00%> (+0.34%) ⬆️

@pichlermarc pichlermarc added this pull request to the merge queue Feb 13, 2025
Merged via the queue into open-telemetry:main with commit b526ec9 Feb 13, 2025
18 checks passed
@pichlermarc pichlermarc deleted the feat/migrate-from-getenv-exporter-jaeger branch February 13, 2025 16:08
trentm pushed a commit to trentm/opentelemetry-js that referenced this pull request Feb 26, 2025
pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

target:next-major-release This PR targets the next major release (`next` branch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants