Skip to content

Conversation

@trentm
Copy link
Contributor

@trentm trentm commented Jun 25, 2025

Fixes: #5755

@trentm trentm self-assigned this Jun 25, 2025
@trentm trentm requested a review from a team as a code owner June 25, 2025 16:23
@codecov
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (019cb2c) to head (737c14a).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5763      +/-   ##
==========================================
- Coverage   95.03%   95.01%   -0.03%     
==========================================
  Files         310      303       -7     
  Lines        7998     7957      -41     
  Branches     1615     1609       -6     
==========================================
- Hits         7601     7560      -41     
  Misses        397      397              
Files with missing lines Coverage Δ
...sdk-metrics/src/aggregator/ExponentialHistogram.ts 98.16% <100.00%> (ø)

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trentm
Copy link
Contributor Author

trentm commented Jun 25, 2025

FWIW, none of the other *Accumulation constructors set a default value for the startTime param:

% cd opentelemetry-js/packages/sdk-metrics/src

% rg public\ startTime:\ HrTime
aggregator/Histogram.ts
68:    public startTime: HrTime,

aggregator/ExponentialHistogram.ts
68:    public startTime: HrTime = startTime,

aggregator/Sum.ts
32:    public startTime: HrTime,

aggregator/LastValue.ts
33:    public startTime: HrTime,

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🙂

@trentm trentm added this pull request to the merge queue Jun 25, 2025
Merged via the queue into open-telemetry:main with commit 8505a61 Jun 25, 2025
25 of 26 checks passed
@trentm trentm deleted the trentm-closurescript-strict-startTime branch June 25, 2025 17:08
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExponentialHistogram has an invalid default param

2 participants