Skip to content

fix(instrumentation-fetch): Handling null-body-status responses #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-luna merged 7 commits into from
Oct 31, 2025
Merged

fix(instrumentation-fetch): Handling null-body-status responses #6037

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4b09457
adding null-body-status response test
m0sa Oct 22, 2025
6ffb168
handling null-body-status response gracefully
m0sa Oct 22, 2025
88f1fbe
adding changelog entry
m0sa Oct 23, 2025
ca8f2ee
md harder
m0sa Oct 23, 2025
32c82fd
using correct assertion
m0sa Oct 23, 2025
20b8698
adding tests for other cases
m0sa Oct 24, 2025
99e4837
removing 101 case
m0sa Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
using correct assertion 
Co-authored-by: Wolfgang Therrien <[email protected]>
  • Loading branch information
@m0sa @wolfgangcodes
m0sa and wolfgangcodes authored Oct 23, 2025
commit 32c82fdc996c6d67a9d60bedf2ec93bf29070d59
4 changes: 2 additions & 2 deletions experimental/packages/opentelemetry-instrumentation-fetch/test/fetch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,8 @@ describe('fetch', () => {
});
response = result.response;
});
it('should be handled correctly', async () => {
assert.strictEqual(response?.status, 204);
it('204 (No Content) will correctly end the span', async () => {
assert.strictEqual(exportedSpans.length, 1);
});
});

Expand Down