Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 29, 2025

Which problem is this PR solving?

There is commented code left over from #5743.

Fixes # N/A

Short description of the changes

This commit removes the commented out code.

Type of change

None of the provided options.

How Has This Been Tested?

  • Run in the CI

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner October 29, 2025 16:39
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.16%. Comparing base (4dc99dc) to head (ef407f7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6062   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         316      316           
  Lines        9207     9207           
  Branches     2075     2075           
=======================================
  Hits         8762     8762           
  Misses        445      445           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag
Copy link
Contributor

I wouldn't consider this a fix, you can tag as chore, and no need for changelog

@maryliag maryliag changed the title fix(instrumentation-http): remove commented out code chore(instrumentation-http): remove commented out code Oct 29, 2025
Co-authored-by: Marylia Gutierrez <[email protected]>
@maryliag maryliag added this pull request to the merge queue Oct 29, 2025
Merged via the queue into open-telemetry:main with commit e01e48d Oct 29, 2025
27 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Oct 29, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the commented-code branch October 29, 2025 18:18
maryliag added a commit to maryliag/opentelemetry-js that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants