Skip to content

fix(plugin-dns): remove from default plugin list #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayurkale22 merged 2 commits into from
Dec 12, 2019
Merged

fix(plugin-dns): remove from default plugin list #613

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b08edfe
fix(plugin-dns): remove from default plugin list
OlivierAlbertini Dec 11, 2019
b40eee6
Merge branch 'master' into feature/remove-dns-in-default
mayurkale22 Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(plugin-dns): remove from default plugin list 
closes #612

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
  • Loading branch information
@OlivierAlbertini
OlivierAlbertini committed Dec 11, 2019
commit b08edfe3e23ae85f44af3b1adcb9b3b5acfeff19
1 change: 0 additions & 1 deletion packages/opentelemetry-node/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ export interface NodeTracerConfig extends BasicTracerConfig {
/** List of all default supported plugins */
export const DEFAULT_INSTRUMENTATION_PLUGINS: Plugins = {
'mongodb-core': { enabled: true, path: '@opentelemetry/plugin-mongodb-core' },
dns: { enabled: true, path: '@opentelemetry/plugin-dns' },
grpc: { enabled: true, path: '@opentelemetry/plugin-grpc' },
http: { enabled: true, path: '@opentelemetry/plugin-http' },
https: { enabled: true, path: '@opentelemetry/plugin-https' },
Expand Down
17 changes: 17 additions & 0 deletions packages/opentelemetry-plugin-dns/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,23 @@ const tracer = new NodeTracer({
});
```

### Zipkin

If you use Zipkin, you must use `ignoreHostnames` in order to not trace those calls. If the server is local. You can set :

```
const tracer = new NodeTracer({
plugins: {
dns: {
enabled: true,
// You may use a package name or absolute path to the file.
path: '@opentelemetry/plugin-dns',
ignoreHostnames: ['localhost']
}
}
});
```

### Dns Plugin Options

Dns plugin has currently one option. You can set the following:
Expand Down