Skip to content

feat(configuration): doesnt set meter, tracer, logger provider by default #6130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryliag merged 11 commits into from
Nov 21, 2025
+983 −1,060
Merged

feat(configuration): doesnt set meter, tracer, logger provider by default #6130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
687dba0
no providers by default
maryliag Nov 19, 2025
b008c45
changelog
maryliag Nov 19, 2025
c49f7d9
Merge branch 'main' of github.com:open-telemetry/opentelemetry-js int…
maryliag Nov 19, 2025
94a898e
update changelog
maryliag Nov 19, 2025
fb9fd37
fix lint
maryliag Nov 19, 2025
c3a1040
invalid providers
maryliag Nov 20, 2025
057a2f6
Merge branch 'main' of github.com:open-telemetry/opentelemetry-js int…
maryliag Nov 20, 2025
3c79831
Merge branch 'main' of github.com:open-telemetry/opentelemetry-js int…
maryliag Nov 20, 2025
e1214d2
check empty array
maryliag Nov 21, 2025
d97d3c5
Merge branch 'main' of github.com:open-telemetry/opentelemetry-js int…
maryliag Nov 21, 2025
4051f21
fix lint
maryliag Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
check empty array
  • Loading branch information
@maryliag
maryliag committed Nov 21, 2025
commit e1214d2d81676eb138f11130a876ed12ad370b07
6 changes: 3 additions & 3 deletions experimental/packages/configuration/src/FileConfigFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ export function setTracerProvider(
}
}
}
} else if (tracerProvider && tracerProvider.processors == null) {
} else if (tracerProvider && (tracerProvider.processors == null || tracerProvider.processors.length === 0)) {
diag.warn('TracerProvider must have at least one processor configured');
}
}
Expand Down Expand Up @@ -1045,7 +1045,7 @@ export function setMeterProvider(
config.meter_provider.views.push(view);
}
}
} else if (meterProvider && meterProvider.readers == null) {
} else if (meterProvider && (meterProvider.readers == null || meterProvider.readers.length === 0)) {
diag.warn('MeterProvider must have at least one reader configured');
}
}
Expand Down Expand Up @@ -1173,7 +1173,7 @@ export function setLoggerProvider(
loggers;
}
}
} else if (loggerProvider && loggerProvider.processors == null) {
} else if (loggerProvider && (loggerProvider.processors == null || loggerProvider.processors.length === 0)) {
diag.warn('LoggerProvider must have at least one processor configured');
}
}
2 changes: 1 addition & 1 deletion experimental/packages/configuration/test/fixtures/invalid-providers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
file_format: "1.0-rc.1"
tracer_provider:
processors:
processors: []
meter_provider:
readers:
logger_provider:
Expand Down
Loading