grpc for node and support for new proto format for node and browser#901
grpc for node and support for new proto format for node and browser#901mayurkale22 merged 20 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #901 +/- ##
==========================================
- Coverage 94.94% 94.69% -0.26%
==========================================
Files 247 247
Lines 11142 11228 +86
Branches 1065 1077 +12
==========================================
+ Hits 10579 10632 +53
- Misses 563 596 +33
|
|
@open-telemetry/javascript-approvers Please review when you get a chance. |
|
Wait with more reviews as I can't make it work with latest otel anyway - will let you know where is the problem when I finish |
packages/opentelemetry-exporter-collector/src/platform/browser/sendSpans.ts
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/node/util.ts
Outdated
Show resolved
Hide resolved
mayurkale22
left a comment
There was a problem hiding this comment.
Added first pass comments.
packages/opentelemetry-core/src/platform/browser/hex-to-bytes.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-exporter-collector/src/platform/browser/sendSpans.ts
Outdated
Show resolved
Hide resolved
|
@obecny why do you think this one has |
|
|
I agree with @obecny on |
mayurkale22
left a comment
There was a problem hiding this comment.
Overall LGTM. Honestly, PR is very big, easy to miss things. I would like to give another pass before approving.
Which problem is this PR solving?
Short description of the changes
Bear in mind that currently there is no yet opentelemetry collector that supports grpc and new format, this needs to wait until this is doneit is there now, tested and fixed