Remove deprecated messages and fields from metrics #342
Conversation
Signed-off-by: Bogdan Drutu <[email protected]>
|
Do we have a green flag on the Collector side? Any components still referencing these fields that need to be fixed (other than pdata package)? |
|
I'd like to be a little more cautious before delivering this. I think once we have most languages up-to-date on the latest metrics specification. Specifically, since we asked SiGs to hold off on metrics until spec was more stable, I think we should also delay the deprecation removal policy on these just a bit. |
|
@jsuereth what is the problem if they have not moved? They will be forced to do this move when upgrade. |
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
From the stability definitions:
"stable" maturity APIs should not introduce backwards-incompatible changes more than once every twelve months, and will make every effort to provide compatibility bridges if at all possible.
These fields were marked deprecated 8 months ago. Is this change compatible with our stability guarantees?
|
@MrAlias yes since it was already "deprecated" when we marked the project stable. We can wait 12m if you think that helps, but I doubt. |
tigrannajaryan
left a comment
tigrannajaryan
left a comment
There was a problem hiding this comment.
LGTM. I don't think we need to wait 12months since deprecation was done before we declared the proto stable (so Beta rules apply in this case, not Stable rules).
I assume we are good on Collector-side since proposed by Bogdan (I didn't check).
SGTM |
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
Revert "Remove deprecated messages and fields from metrics (open-telemetry#342)"
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
…metry#342)" This reverts commit 8ba33cc.
5 participants
Signed-off-by: Bogdan Drutu [email protected]