Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change span_exporter_names to trace_exporter_names
  • Loading branch information
jeremydvoss committed May 30, 2024
commit a3f0475cf45d533b16c1558722ac5792c4df1481
Original file line number Diff line number Diff line change
Expand Up @@ -356,22 +356,22 @@ def _import_id_generator(id_generator_name: str) -> IdGenerator:

def _initialize_components(
auto_instrumentation_version: Optional[str] = None,
span_exporter_names: Optional[List[str]] = None,
trace_exporter_names: Optional[List[str]] = None,
metric_exporter_names: Optional[List[str]] = None,
log_exporter_names: Optional[List[str]] = None,
sampler: Optional[Sampler] = None,
resource_attributes: Optional[Attributes] = None,
id_generator: IdGenerator = None,
logging_enabled: Optional[bool] = None,
):
if span_exporter_names is None:
span_exporter_names = []
if trace_exporter_names is None:
trace_exporter_names = []
if metric_exporter_names is None:
metric_exporter_names = []
if log_exporter_names is None:
log_exporter_names = []
span_exporters, metric_exporters, log_exporters = _import_exporters(
span_exporter_names + _get_exporter_names("traces"),
trace_exporter_names + _get_exporter_names("traces"),
metric_exporter_names + _get_exporter_names("metrics"),
log_exporter_names + _get_exporter_names("logs"),
)
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/tests/test_configurator.py
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,7 @@ def test_initialize_components_kwargs(
resource_mock.create.return_value = "TEST_RESOURCE"
kwargs = {
"auto_instrumentation_version": "auto-version",
"span_exporter_names": ["custom_span_exporter"],
"trace_exporter_names": ["custom_span_exporter"],
"metric_exporter_names": ["custom_metric_exporter"],
"log_exporter_names": ["custom_log_exporter"],
"sampler": "TEST_SAMPLER",
Expand Down